Skip to content

[fga] migrated user service methods #18461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2023
Merged

[fga] migrated user service methods #18461

merged 1 commit into from
Aug 9, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Aug 8, 2023 •
edited by github-actions bot
Loading

Description

Extracts the following methods from gitpod-server-impl.ts to user-service.ts and adds test and FGA logic for them:

  • listUsers
  • updateRolesOrPermissions
  • updateWorkspaceTimeoutSetting
Summary generated by Copilot

🤖 Generated by Copilot at 90d73ba

This pull request adds new features and tests to the UserService module, which handles user-related operations in the server component. It also updates the GitpodServerImpl class to use the UserService methods, and the spicedb schema to define a new permission for installation admins.

Related Issue(s)

Fixes EXP-316
Fixes EXP-396
Fixes EXP-397

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@svenefftinge svenefftinge requested a review from a team as a code owner August 8, 2023 14:50
akosyakov
akosyakov approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good, but i did not test

/hold

I think it makes sense to smoke test some features like gp timeout set/get from the workspace once

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 9b06d2e into main Aug 9, 2023
@roboquat roboquat deleted the se/user-service3 branch August 9, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
size/L team: team-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenefftinge @akosyakov @roboquat